Skip to content

Allow macros to be a dict in service-apply-rules#2387

Open
Yoda-BZH wants to merge 7 commits intoIcinga:masterfrom
Yoda-BZH:master
Open

Allow macros to be a dict in service-apply-rules#2387
Yoda-BZH wants to merge 7 commits intoIcinga:masterfrom
Yoda-BZH:master

Conversation

@Yoda-BZH
Copy link
Copy Markdown

@Yoda-BZH Yoda-BZH commented Sep 8, 2021

Same as #1453, #2085 or #2446

In Service-Apply-Rules macros like $config.property$ should be evaluated, currently the only macro that gets evaluated is $config$

also fixes #2083, fixes #2432.

This method doesn't need toConfigString modification.

This PR contains tests against this modification.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Sep 8, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Sep 8, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Sep 8, 2021

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Yoda-BZH

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@Yoda-BZH
Copy link
Copy Markdown
Author

Yoda-BZH commented Sep 8, 2021

verified.

@bobapple
Copy link
Copy Markdown
Member

bobapple commented Sep 8, 2021

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed label Sep 8, 2021
@Yoda-BZH
Copy link
Copy Markdown
Author

Yoda-BZH commented Sep 9, 2021

thank you.

Is there a way to run the CI against my PR ?

@Yoda-BZH
Copy link
Copy Markdown
Author

any news ?

@jcourreges
Copy link
Copy Markdown

Hi. At $DAYJOB we're depending on this change as a local patch. It would be nice to drop the patch and share the improved functionality with everybody. 🙂

@tonyvroon
Copy link
Copy Markdown

Also depending on this change in production, any chance of this being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for more then just $config$ in Service Apply For Rule properties Using macro sub-properties not working in Service Apply Rules

4 participants