Allow macros to be a dict in service-apply-rules#2387
Allow macros to be a dict in service-apply-rules#2387Yoda-BZH wants to merge 7 commits intoIcinga:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau.
|
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Yoda-BZH Details
|
|
verified. |
|
@cla-bot check |
|
thank you. Is there a way to run the CI against my PR ? |
|
any news ? |
|
Hi. At $DAYJOB we're depending on this change as a local patch. It would be nice to drop the patch and share the improved functionality with everybody. 🙂 |
|
Also depending on this change in production, any chance of this being merged? |
Same as #1453, #2085 or #2446
In Service-Apply-Rules macros like
$config.property$should be evaluated, currently the only macro that gets evaluated is$config$also fixes #2083, fixes #2432.
This method doesn't need
toConfigStringmodification.This PR contains tests against this modification.